-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WAMP #573
Conversation
pkg/wamp/WampConsumer.php
Outdated
*/ | ||
public function acknowledge(Message $message): void | ||
{ | ||
// do nothing. redis transport always works in auto ack mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redis -> wamp
pkg/wamp/WampConsumer.php
Outdated
{ | ||
InvalidMessageException::assertMessageInstanceOf($message, WampMessage::class); | ||
|
||
// do nothing on reject. redis transport always works in auto ack mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
pkg/wamp/WampMessage.php
Outdated
$this->redelivered = false; | ||
} | ||
|
||
public function jsonSerialize(): array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you use a concept from rdkafka transport (with a serializer interface)?
pkg/wamp/LICENSE
Outdated
@@ -0,0 +1,20 @@ | |||
The MIT License (MIT) | |||
Copyright (c) 2017 Kotliar Maksym |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright (c) 2018 Forma-Pro
pkg/wamp/README.md
Outdated
@@ -0,0 +1,27 @@ | |||
# Web Application Messaging Protocol Transport |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`# Web Application Messaging Protocol (WAMP) Transport
pkg/wamp/WampConsumer.php
Outdated
|
||
$this->client->getLoop()->run(); | ||
|
||
return $this->message ?: null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will have 100 clients in the context if we receive 100 message, right? Could we somehow reset them once a message has been received ?
Add docs, update readme. |
resolve conflicts |
pkg/wamp/WampConnectionFactory.php
Outdated
{ | ||
$dsn = new Dsn($dsn); | ||
|
||
if ('wamp' !== $dsn->getSchemeProtocol()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wamp and ws
Web Application Messaging Protocol (WAMP) Transport
A transport for Web Application Messaging Protocol.
WAMP is an open standard WebSocket subprotocol.
It uses internally Thruway PHP library voryx/thruway
Installation
Start the WAMP router
Thruway is now running on 127.0.0.1 port 9090
Create context
Consume message:
Start message consumer before send message to the topic
Subscription consumer
Send message to topic
back to index