Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rdkafka] Use default queue as router topic #567

Merged
merged 1 commit into from
Oct 18, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions pkg/enqueue/Client/Driver/RdKafkaDriver.php
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
<?php

declare(strict_types=1);

namespace Enqueue\Client\Driver;

use Enqueue\RdKafka\RdKafkaContext;
use Enqueue\RdKafka\RdKafkaTopic;
use Interop\Queue\Destination;
use Psr\Log\LoggerInterface;
use Psr\Log\NullLogger;

Expand Down Expand Up @@ -44,14 +45,4 @@ public function setupBroker(LoggerInterface $logger = null): void
$this->getContext()->createConsumer($queue);
}
}

/**
* @return RdKafkaTopic
*/
protected function createRouterTopic(): Destination
{
return $this->doCreateTopic(
$this->createTransportRouterTopicName($this->getConfig()->getRouterTopic(), true)
);
}
}
2 changes: 2 additions & 0 deletions pkg/enqueue/Client/Driver/RedisDriver.php
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
<?php

declare(strict_types=1);

namespace Enqueue\Client\Driver;

use Enqueue\Redis\RedisContext;
Expand Down
5 changes: 0 additions & 5 deletions pkg/enqueue/Tests/Client/Driver/RdKafkaDriverTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -118,11 +118,6 @@ protected function createMessage(): InteropMessage
return new RdKafkaMessage();
}

protected function getRouterTransportName(): string
{
return 'aprefix.router';
}

/**
* @return Config
*/
Expand Down