-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Localstack Docker container for SQS functional tests #473
Add Localstack Docker container for SQS functional tests #473
Conversation
We do not need a real sqs service, do we? This is great! The check in tests could be removed and tests are adjusted to use local stack instance. |
For some reason, the AWS env vars are going missing on Travis even though they work when I run the tests locally. Still trying to figure out why. |
Because there are ones added by travis, they are encrypted. Travis removes them from a build if run by someone, not from enqueue organization. |
I've removed them. |
@makasim Are you able to kick off a build for this PR that passes? |
@makasim Is there further action on my part that's needed to get this merged? |
@@ -1,9 +1,6 @@ | |||
parameters: | |||
locale: 'en' | |||
secret: 'ThisTokenIsNotSoSecretChangeIt' | |||
env(AWS_SQS_REGION): 'us-east-1' | |||
env(AWS_SQS_KEY): 'key' | |||
env(AWS_SQS_SECRET): 'secret' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add them back, and add AWS_SQS_ENDPOINT too.
@elazar are we good to go? |
@makasim Appears so. I was trying to avoid duplicating the env vars in |
@makasim Any else need changing on this PR, or is it good to merge? |
Sorry, forgot about it. merged. |
Awesome, thanks! 😄 |
Add Localstack Docker container for SQS functional tests
While testing my changes from #444, I noticed that the following tests are skipped in the build because there is presently no local SQS instance to test against.
This PR adds a LocalStack Docker container that allows these tests to be run in the build.