Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[consumption] add process niceness extension #467

Merged
merged 1 commit into from
Jul 19, 2018
Merged

[consumption] add process niceness extension #467

merged 1 commit into from
Jul 19, 2018

Conversation

ramunasd
Copy link
Contributor

fix #449

@ramunasd ramunasd force-pushed the extension_niceness branch from 2229687 to 65b32a5 Compare June 24, 2018 10:57
makasim
makasim reviewed Jul 10, 2018
View reviewed changes
pkg/enqueue/Consumption/Extension/NicenessExtension.php Outdated
));
}

if (0 !== $niceness) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has to be done onStart

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

makasim
makasim reviewed Jul 10, 2018
View reviewed changes
pkg/enqueue/Symfony/Consumption/LimitsExtensionsCommandTrait.php Outdated
@@ -58,6 +60,11 @@ protected function getLimitsExtensions(InputInterface $input, OutputInterface $o
$extensions[] = new LimitConsumerMemoryExtension($memoryLimit);
}

$niceness = (int) $input->getOption('niceness');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should not force int but check if the option is number and if not throw an exception with the message that explains it shuld be int.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check already is in constructor of extension. Do we really need additional one?

@ramunasd ramunasd force-pushed the extension_niceness branch from 65b32a5 to 70bfc63 Compare July 10, 2018 20:46
@makasim makasim merged commit 22e5315 into php-enqueue:master Jul 19, 2018
ASKozienko pushed a commit that referenced this pull request Nov 2, 2018
@makasim
Merge pull request #467 from ramunasd/extension_niceness
5df95c6 
[consumption] add process niceness extension
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makasim makasim makasim left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[consumption] process niceness extension
2 participants
@ramunasd @makasim