[bundle] Fix panel rendering when message body is an object #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makasim
reviewed
May 10, 2018
| >Show body</a> | ||
| <div id="message-body-{{ loop.index }}" | ||
| class="context sf-toggle-content sf-toggle-hidden"> | ||
| <pre>{{ body }}</pre> |
There was a problem hiding this comment.
why dont you use profiler_dump here?
There was a problem hiding this comment.
The profiler_dump expects a Data object and fails when the $body is an object.
The change here ensures the displayed value is a json string
There was a problem hiding this comment.
@makasim any updates on this?
ASKozienko
pushed a commit
that referenced
this pull request
Nov 2, 2018
[bundle] Fix panel rendering when message body is an object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.