Disable sleep while queue items available #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…requests add subscription_interval as config for dbal subscription consumer
…continue processing the queues!
|
I like! |
|
I've hesitated with merging this because I am not sure I can spot all the possible scenario and bugs it might introduce. On the other hand, I dont want to be a blocker for improvements. I can merge if you are sure it works well. Please tell. |
|
@makasim we are using it in a productive environment already since the 10th January 2022 and we have daily between 200.000 and 300.000 items in ~40 queues. Based on that I am 100% sure that it works! :) |
|
@mordilion thanks! |
|
@makasim thanks for merging it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is disabling the Subscription-Polling-Sleep as long there are items in queues. If there are no items in queues, then the gathering of items is not constantly penetrating the Database.
We are using it already in our production environment and it works perfectly fine without any Database issues.