Add setTopicArn methods to SnsContext and SnsQsContext

[gdsmith]

Enables us to prevent #1188

[andrewmy]

Is there any particular reason for these formatting changes? IMO they reduce readability.

[gdsmith]

No. Think that must have happened as part of the rebase.

…

On Thu, 19 Aug 2021, 14:53 Andrew, ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In pkg/snsqs/SnsQsContext.php <#1189 (comment)> : > @@ -53,23 +53,15 @@ public function __construct($snsContext, $sqsContext) } elseif (is_callable($snsContext)) { $this->snsContextFactory = $snsContext; } else { - throw new \InvalidArgumentException(sprintf( - 'The $snsContext argument must be either %s or callable that returns %s once called.', - SnsContext::class, - SnsContext::class - )); + throw new \InvalidArgumentException(sprintf('The $snsContext argument must be either %s or callable that returns %s once called.', SnsContext::class, SnsContext::class)); Is there any particular reason for these formatting changes? IMO they reduce readability. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1189 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAG53F67TNXSZHMCCT5OCKDT5TPCDANCNFSM5BH3I3GA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

[andrewmy]

Pretty sure I saw them before the rebase as well.

[gdsmith]

Changes are from composer cs-fix. I can revert them if you'd prefer

[gdsmith]

Actually, seems like this would fail the build if I revert those changes:

./bin/php-cs-fixer fix --config=.php_cs.php --no-interaction --dry-run --diff -v --path-mode=intersection -- 'pkg/sns/SnsContext.php' 'pkg/snsqs/SnsQsContext.php'
PHP CS Fixer 2.18.6 Remote Void by Fabien Potencier and Dariusz Ruminski
Runtime: PHP 7.3.11
Loaded config default from ".php_cs.php".
Using cache file "/Volumes/Mukuru/taurus/third-party/enqueue-dev/var/.php_cs.cache".
SF
Legend: ?-unknown, I-invalid file syntax (file ignored), S-skipped (cached or empty file), .-no changes, F-fixed, E-error
   1) /Volumes/Mukuru/taurus/third-party/enqueue-dev/pkg/snsqs/SnsQsContext.php (single_line_throw)
      ---------- begin diff ----------
--- Original
+++ New
@@ @@
         } else {
-            throw new \InvalidArgumentException(sprintf(
-                'The $snsContext argument must be either %s or callable that returns %s once called.',
-                SnsContext::class,
-                SnsContext::class)
-            );
+            throw new \InvalidArgumentException(sprintf('The $snsContext argument must be either %s or callable that returns %s once called.', SnsContext::class, SnsContext::class));
@@ @@
         } else {
-            throw new \InvalidArgumentException(sprintf(
-                'The $sqsContext argument must be either %s or callable that returns %s once called.',
-                SqsContext::class,
-                SqsContext::class)
-            );
+            throw new \InvalidArgumentException(sprintf('The $sqsContext argument must be either %s or callable that returns %s once called.', SqsContext::class, SqsContext::class));
         }

[andrewmy]

Wow ok :D

[gdsmith]

So is this good for deploy and release now 🤞