Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dbal delivery delay to always keep integer value #1161

Merged
merged 2 commits into from
Apr 28, 2021

Conversation

dgafka
Copy link
Contributor

@dgafka dgafka commented Apr 23, 2021

Fixes incorrect calculations that may result in float instead of int:

SQLSTATE[22P02]: Invalid text representation: 7 ERROR: invalid input syntax for integer: \"1619173911.5\" at /data/app/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/AbstractPostgreSQLDriver.php:102, Doctrine\\DBAL\\Driver\\PDO\\Exception(code: 22P02): SQLSTATE[22P02]: Invalid text representation: 7 ERROR: invalid input syntax for integer: \"1619173911.5\" at /data/app/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDO/Exception.php:18, PDOException(code: 22P02): SQLSTATE[22P02]: Invalid text representation: 7 ERROR: invalid input syntax for integer: \"1619173911.5\" at /data/app/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php:115)

@dgafka dgafka changed the title Fix dbal delivery delay to always keep integer Fix dbal delivery delay to always keep integer value Apr 23, 2021
@makasim
Copy link
Member

makasim commented Apr 28, 2021

Tests have to be fixed

@dgafka
Copy link
Contributor Author

dgafka commented Apr 28, 2021

@makasim tests are fixed now :)

@makasim
Copy link
Member

makasim commented Apr 28, 2021

Thanks!

@makasim makasim merged commit 33c2490 into php-enqueue:master Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants