Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add subscription_interval as config for dbal subscription consumer #1159

Merged

Conversation

mordilion
Copy link
Contributor

@mordilion mordilion commented Apr 21, 2021

I am facing an issue with the situation, that I have a few JobWorker running and my DB doesn't like that many requests. Without the change, I am getting 50 Requests in 10 Seconds with 1 JobWorker. Because of this, I am getting many "MySQL Server has gone away" messages.

@mordilion
Copy link
Contributor Author

@makasim is it possible to get at least a short feedback for my Pull-Request? Right now I am patching my Code every time to get that option. At least a "No" would be nice, because then I could start looking for another Library.

In my opinion, it would make sense to add that option. :)

pkg/dbal/DbalSubscriptionConsumer.php Outdated Show resolved Hide resolved
@makasim
Copy link
Member

makasim commented Apr 28, 2021

In general it looks good.

Copy link
Contributor Author

@mordilion mordilion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the naming :)

pkg/dbal/DbalSubscriptionConsumer.php Outdated Show resolved Hide resolved
@mordilion mordilion requested a review from makasim April 28, 2021 11:29
@makasim makasim merged commit 25601f3 into php-enqueue:master Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants