[gps] Add support for consuming message from external publisher in non-standard format #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, I've added a couple of unit tests to for these 2 different scenarios, and now I'd say it's ready for merge if it's ok for you. That failed phpcs test I don't agree with (and local phpcs doesn't agree with it either) (plus, I haven't changed anything there either, so 🤷). Into your hands @makasim for a review! |
maciejzgadzaj
force-pushed
the
1117-consume-non-standard-message-format
branch
8 times, most recently
from
56618cc to
d863a55
Compare
maciejzgadzaj
force-pushed
the
1117-consume-non-standard-message-format
branch
from
d863a55 to
01a2f8c
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
maciejzgadzaj
force-pushed
the
1117-consume-non-standard-message-format
branch
from
01a2f8c to
e1c3d82
Compare
…n-standard format
maciejzgadzaj
force-pushed
the
1117-consume-non-standard-message-format
branch
from
e1c3d82 to
ffe8590
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #1117