Added: ability to choose different entity manager #1081
Conversation
Changed: job queue documentation
|
LGTM. All that is left is for @makasim to review. |
| @@ -171,6 +171,14 @@ private function registerJobQueueDoctrineEntityMapping(ContainerBuilder $contain | |||
| return; | |||
| } | |||
|
|
|||
| foreach ($container->getExtensionConfig('enqueue') as $modules) { | |||
| foreach ($modules as $config) { | |||
| if (isset($config['job']) && false === $config['job']['default_mapping']) { | |||
There was a problem hiding this comment.
That does not look accurate. For example one config defines false and the next defines true. The merged value might be true but this logic would not load default entites.
There must be a method that allows getting merged version of the config. But I am not sure. Could you please look for it?
There was a problem hiding this comment.
Sorry for taking so long.
I was not able to find a solution for this yet, but this part of code is happening before the merging of configuration, no?
There was a problem hiding this comment.
You should merge it manually and use the result in condition.
There was a problem hiding this comment.
Symfony provides tools for that.
There was a problem hiding this comment.
https://symfony.com/doc/current/bundles/configuration.html#processing-the-configs-array
EDIT: However I'm surprised that the configuration isn't already resolved at this point. Processing it more than once should not be an issue, since in production it would be cached if I understand correctly, but still...
|
Hey @Steveb-p , maybe you know what exactly causes the tests to fail?
Before the last code fix, all tests passed, but the |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
hey @makasim, would you mind reviewing this PR one more time? |
Fixed issues of #1042