SQS Transport - Add support for AWS profiles. #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bgaillard you can use github-specific keywords to automatically close some issues when PRs are resolved - see https://help.github.com/en/github/managing-your-work-on-github/closing-issues-using-keywords |
Steveb-p
reviewed
Jan 8, 2020
Steveb-p
approved these changes
Jan 8, 2020
|
@Steveb-p Ok, did not know this, thanks. Since your last review I just changed file https://github.com/php-enqueue/enqueue-dev/pull/1008/files#diff-663c8e41658b32f3c5e6dfd4bee59e96 to make CI pass. I think everything is good to merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support for AWS profiles, it reponds to issue #1007.
Closes: #1007