Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Redis] default timeout setting makes connection impossible #525

Closed
jeff1985 opened this issue Sep 7, 2018 · 1 comment · Fixed by #526
Closed

[Redis] default timeout setting makes connection impossible #525

jeff1985 opened this issue Sep 7, 2018 · 1 comment · Fixed by #526
Milestone

Comments

@jeff1985
Copy link
Contributor

jeff1985 commented Sep 7, 2018

With this commit you've added a default value of .0for the timeout. For predis this actually means "zero seconds" which prevents any connections to be established in my case. I always get "Connection timed out" unless I actually set a non-zero timeout in my DSN string.

The default setting in predis is 5.0, so I guess you should set this default setting or leave it at null.

Also see diff here: php-enqueue/redis@64d907a#diff-f12a3e81838b8c1f6057268e5b96bb3fR166

@makasim
Copy link
Member

makasim commented Sep 7, 2018

@jeff1985 I'll fix it asap.

makasim added a commit that referenced this issue Sep 7, 2018
makasim added a commit to php-enqueue/redis that referenced this issue Sep 7, 2018
ASKozienko pushed a commit that referenced this issue Nov 2, 2018
@makasim makasim added this to the 0.9 milestone Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants