Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception in message processor causes consumer to exit #240

Closed
bwegrzyn opened this issue Oct 20, 2017 · 2 comments · Fixed by #283
Closed

Exception in message processor causes consumer to exit #240

bwegrzyn opened this issue Oct 20, 2017 · 2 comments · Fixed by #283
Labels

Comments

@bwegrzyn
Copy link

According to the documentation, it says that usually you do not need to catch exceptions in the message processor.

Currently, if an exception occurs, the consumer process exits completely instead of logging an error.

I can wrap my processors in a try/catch, but it would be a nice improvement to have the consumer automatically catch exceptions and log them.

@makasim
Copy link
Member

makasim commented Oct 20, 2017

That's expected behavior, a consumer has to fail fast for various reasons.

We discussed that several times some time ago and came to a conclusion that this is the right behavior.

@bwegrzyn
Copy link
Author

Ok, that makes sense. Maybe the documentation could be a little clearer on that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants