Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDKafka full support for PHP 8.1 #1234

Closed
Wirone opened this issue Feb 1, 2022 · 15 comments
Closed

RDKafka full support for PHP 8.1 #1234

Wirone opened this issue Feb 1, 2022 · 15 comments

Comments

@Wirone
Copy link

Wirone commented Feb 1, 2022

In theory, enqueue/rdkafka already supports PHP 8.1 (because of require php: ^7.3|^8.0), but RDKafka extension supports PHP 8.1 in 6.0.0, which is not supported by the package itself (because of ext-rdkafka: ^4.0|^5.0 requirement).

Please provide full support for PHP 8.1.

@makasim
Copy link
Member

makasim commented Feb 2, 2022

Could work on pull request ?

@Wirone
Copy link
Author

Wirone commented Feb 2, 2022

If changing constraint by adding |^6.0 is enough I can create PR, but I don't have enough knowledge about rdkafka and this package to go deeper 🙂

@Steveb-p
Copy link
Contributor

Steveb-p commented Feb 2, 2022

Changing the constraint should be enough: https://github.com/arnaud-lb/php-rdkafka/releases/tag/6.0.0

Wirone added a commit to Wirone/enqueue-dev that referenced this issue Feb 2, 2022
This was referenced Feb 2, 2022
@lucasrivoiro
Copy link
Contributor

Please, when this update will be available for us? I have a new project and I wanna use this lib with rdkafka 6.0

@makasim
Copy link
Member

makasim commented Feb 17, 2022

This is available as dev version. Could you test it ?

@lucasrivoiro
Copy link
Contributor

Here works fine on PHP 8.1 with RDKafka 6 and Kafka 3.1.0. I made a PR in enqueue/rdkafka project. The PR should be send in php-enqueue/enqueue-dev or in enqueue/rdkafka?

@makasim
Copy link
Member

makasim commented Feb 23, 2022

All changes have to be done in php-enqueue/enqueue-dev. enqueue/rdkafka is read-only mirror which I update from time to time manually.

@qkdreyer
Copy link
Contributor

Can we get a release instead of the dev version ?

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 16, 2022
@qkdreyer
Copy link
Contributor

Bump @makasim

@stale stale bot removed the wontfix label Apr 16, 2022
@makasim
Copy link
Member

makasim commented Apr 17, 2022

@qkdreyer what do you expect from me?

@qkdreyer
Copy link
Contributor

Wondering if we could get a released version on packagist

@Wirone
Copy link
Author

Wirone commented Jun 23, 2022

@makasim please release enqueue/rdkafka 0.10.17 with this change so we can close the issue and use it properly (with a semver constraint, not with commit sha)?

@qkdreyer
Copy link
Contributor

@Wirone you can use enqueue/rdkafka:0.10.16 since it has been released on packagist on may

@Wirone
Copy link
Author

Wirone commented Jun 23, 2022

@makasim sorry for the noise, Packagist tricked me:
image
I did not verify it properly 🙄

I'll close this now 👍

@Wirone Wirone closed this as completed Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants