[WIP] PR for testing danger

[php-coder]

See https://github.com/danger/danger

• look at https://github.com/danger/danger/blob/master/Dangerfile
• look at https://github.com/artsy/eigen/blob/master/Dangerfile
• read http://danger.systems/reference.html
• read http://danger.systems/guides/dangerfile.html
• read http://danger.systems/guides/a_quick_ruby_overview.html
• read http://danger.systems/guides/creating_your_first_plugin.html
• read http://danger.systems/guides/faq.html
• read http://danger.systems/guides/troubleshooting.html
• try to hide token

[mystamps-bot]

	10 Errors
🚫	codenarc-maven-plugin error in src/test/groovy/ru/mystamps/web/feature/collection/CollectionServiceImplTest.groovy#L112: The String ‘any-login’ can be wrapped in single quotes instead of double quotes
🚫	license-maven-plugin reported about 9 errors: Some problems were encountered while building the effective model for ru.mystamps:mystamps:war:0.4.2-SNAPSHOT 'dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: junit:junit:jar -> version ${junit.version} vs 4.12 @ line 418, column 15 It is highly recommended to fix these problems because they threaten the stability of your build. For this reason, future Maven versions might no longer support building such malformed projects. Missing header in: src/main/java/ru/mystamps/web/feature/series/importing/SeriesImportDb.java#L1 Please, fix them by executing mvn license:format See also: https://github.com/php-coder/mystamps/wiki/check-license-header
🚫	bootlint error in src/main/webapp/WEB-INF/views/site/events.html#L160: E013: Only columns (.col-*-*) may be children of .rows
🚫	bootlint error in src/main/webapp/WEB-INF/views/series/info.html#L105: E042: .form-control cannot be used on non-textual <input>s, such as those whose type is: file, checkbox, radio, range, button
🚫	bootlint error in src/main/webapp/WEB-INF/views/series/add.html#L250: E042: .form-control cannot be used on non-textual <input>s, such as those whose type is: file, checkbox, radio, range, button
🚫	rflint error in src/test/robotframework/selenium.utils.robot#L65: Line has trailing whitespace
🚫	html5validator error in src/main/webapp/WEB-INF/views/site/events.html#L15: Element “head” is missing a required instance of child element “title”
🚫	html5validator error in src/main/webapp/WEB-INF/views/participant/add.html#L172: Element name “th:block” cannot be represented as XML 1.0
🚫	html5validator error in src/main/webapp/WEB-INF/views/participant/add.html#L172: Element “th:block” not allowed as child of element “body” in this context. (Suppressing further errors from this subtree.)
🚫	maven-compiler-plugin has failed. Please, fix compilation errors. Here is its output: [INFO] --- maven-compiler-plugin:3.7.0:compile (default-compile) @ mystamps --- [INFO] Changes detected - recompiling the module! [INFO] Compiling 348 source files to /home/travis/build/php-coder/mystamps/target/classes [INFO] ------------------------------------------------------------- [ERROR] COMPILATION ERROR : [INFO] ------------------------------------------------------------- [ERROR] /home/travis/build/php-coder/mystamps/src/main/java/ru/mystamps/web/feature/site/CronServiceImpl.java:[18] error: An unhandled exception was thrown by the Error Prone static analysis plugin. Please report this at https://github.com/google/error-prone/issues/new and include the following: error-prone version: 2.3.3 BugPattern: UnusedVariable Stack Trace: java.lang.IllegalArgumentException: invalid replacement: [1842, -1) () at com.google.common.base.Preconditions.checkArgument(Preconditions.java:458) at com.google.errorprone.fixes.Replacement.create(Replacement.java:37) at com.google.errorprone.fixes.SuggestedFix$ReplacementFix.getReplacement(SuggestedFix.java:397) at com.google.errorprone.fixes.SuggestedFix.getReplacements(SuggestedFix.java:91) at com.google.errorprone.fixes.AppliedFix$Applier.apply(AppliedFix.java:71) at com.google.errorprone.JavacErrorDescriptionListener.lambda$new$0(JavacErrorDescriptionListener.java:71) at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193) at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:175) at java.util.Collections$2.tryAdvance(Collections.java:4719) at java.util.Collections$2.forEachRemaining(Collections.java:4727) at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482) at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472) at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708) at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:566) at com.google.errorprone.JavacErrorDescriptionListener.onDescribed(JavacErrorDescriptionListener.java:84) at com.google.errorprone.ErrorProneAnalyzer.lambda$finished$1(ErrorProneAnalyzer.java:136) at com.google.errorprone.VisitorState.reportMatch(VisitorState.java:282) at com.google.errorprone.bugpatterns.UnusedVariable.matchCompilationUnit(UnusedVariable.java:241) at com.google.errorprone.scanner.ErrorProneScanner.processMatchers(ErrorProneScanner.java:433) at com.google.errorprone.scanner.ErrorProneScanner.visitCompilationUnit(ErrorProneScanner.java:541) at com.google.errorprone.scanner.ErrorProneScanner.visitCompilationUnit(ErrorProneScanner.java:150) at com.sun.tools.javac.tree.JCTree$JCCompilationUnit.accept(JCTree.java:591) at com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:56) at com.google.errorprone.scanner.Scanner.scan(Scanner.java:55) at com.google.errorprone.scanner.ErrorProneScannerTransformer.apply(ErrorProneScannerTransformer.java:43) at com.google.errorprone.ErrorProneAnalyzer.finished(ErrorProneAnalyzer.java:151) at com.sun.tools.javac.api.MultiTaskListener.finished(MultiTaskListener.java:120) at com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1404) at com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1353) at com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:946) at com.sun.tools.javac.main.Main.compile(Main.java:302) at com.sun.tools.javac.main.Main.compile(Main.java:162) at com.sun.tools.javac.Main.compile(Main.java:57) at com.sun.tools.javac.Main.main(Main.java:43) [INFO] 1 error [INFO] ------------------------------------------------------------- </

	4 Warnings
⚠️	danger check: pull request description doesn’t contain a link to original issue. Consider adding a comment in the following format: Addressed to #XXX where XXX is an issue number
⚠️	danger check: pull request contains 19 commits while most of the cases it should have only one. If it’s not a special case you should squash the commits into single one. But be careful because it can destroy all your changes!
⚠️	danger check: branch test_pr_for_danger does not comply with our best practices. Branch name should use the following scheme: ghXXX_meaningful-name where XXX is an issue number. Next time, please, use this scheme :)
⚠️	danger check: looks like you forgot to update ResourceUrl.RESOURCES_VERSION after modifying JS/CSS file(s)

	5 Messages
📖	codenarc-maven-plugin reported about 1 error. Please, fix it. See also: https://github.com/php-coder/mystamps/wiki/codenarc
📖	license-maven-plugin reported about 1 error. Please, fix it.
📖	bootlint reported about 3 errors. Please, fix them.
📖	rflint reported about 1 error. Please, fix it. See also: https://github.com/php-coder/mystamps/wiki/rflint
📖	html5validator reported about 3 errors. Please, fix them.

Generated by 🚫 Danger

[php-coder]

Quick how to on run/test it locally:

• install danger with its dependencies (gem install danger bundler nokogiri --no-ri --no-rdoc)
• git checkout test_pr_for_danger
• run some checks and generate expected *.log files for danger
• danger pr https://github.com/php-coder/mystamps/pull/533

[php-coder]

I have decided discontinue usage of Danger (see #1600).