Minor cosmetic fixes, add few comments/questions. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will do, thanks |
creack
commented
Oct 28, 2023
| // | ||
| // ref: https://pkg.go.dev/[email protected]?GOOS=windows#LoadDLL | ||
| // Ref: https://pkg.go.dev/[email protected]?GOOS=windows#LoadDLL | ||
| kernel32DLL = windows.NewLazyDLL("kernel32.dll") |
There was a problem hiding this comment.
Isn't it a concern that this will be executed by anyone importing the package, even if they don't use it?
There was a problem hiding this comment.
I don't think it's a concern since the windows package also does it this way. We are not actually loading the DLL. The DLL is loaded when we call the Find method if it is not already loaded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably nothing, but there were a few places where the error was ignored due to scope. Added a few todos, if you could double check it would be great.
Almsot there :)