Remove erroneous sideEffects in package.json
#7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This unfortunately entirely breaks tree-shaking of the library, but pending resolution of vuejs/rollup-plugin-vue#401 that's not something we can fix on our end. This takes the approach that working-but-too-big is at least better than not-working-at-all.
|
Any chance this will get merged soon @brlodi ? Currently using the library and would rather have the entire bundle than none at all. |
|
I don't have write access, so it's up to @rektdeckard |
|
Hey y'all, apologies for the radio silence. Day job really took over. Merged and going live today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unfortunately entirely breaks tree-shaking of the library, but pending resolution of vuejs/rollup-plugin-vue#401 that's not something we can really fix on our end. This takes the approach that working-but-too-big is at least better than not working at all.
I'll explore options for directly using the
.vuefiles from the src directory, but currently the@→srcalias makes them break in dependent projects.