Skip to content
This repository has been archived by the owner on Sep 4, 2020. It is now read-only.

fix issue #41 #44

Merged
merged 3 commits into from
Jul 20, 2015
Merged

fix issue #41 #44

merged 3 commits into from
Jul 20, 2015

Conversation

ashconnell
Copy link
Contributor

This fixed #41 and adds a foreground boolean the same as on Android

@ashconnell ashconnell changed the title fix issue41 fix issue #41 Jul 15, 2015
@macdonst
Copy link
Member

@Deminetix can you modify your fix so that is sets foreground to true when isInline is true and sets foreground to false when isInline is false. Then I'll test your PR and merge.

@ashconnell
Copy link
Contributor Author

@macdonst i'm not sure i follow. What was the original intention of the isInline variable?

@macdonst
Copy link
Member

I don't even think we need to be this fancy. The 'notificationReceived' method only gets called when the app is the the foreground.

macdonst added a commit that referenced this pull request Jul 20, 2015
@macdonst macdonst merged commit f79bd8d into phonegap:master Jul 20, 2015
@macdonst
Copy link
Member

@Deminetix okay, I merged this in but I will do the quick addition to set foreground to false myself.

I really appreciate you stepping up to help out with this plugin. Finally a minor point, check out Chris' slides on commit messages. Something like this PR could be rebased so it is all one commit instead of 3.

https://github.com/CSilivestru/git-different

@lock
Copy link

lock bot commented Jun 3, 2018

This thread has been automatically locked.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

iOS doesn't add foreground key
2 participants