Skip to content
This repository was archived by the owner on Sep 4, 2020. It is now read-only.

Commit

Permalink
Issue #117: iOS notification from cold boot
Browse files Browse the repository at this point in the history
  • Loading branch information
@macdonst
macdonst committed Sep 14, 2015
1 parent 020f1e3 commit 9f35486
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/ios/PushPlugin.m
View file
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ - (void)didFailToRegisterForRemoteNotificationsWithError:(NSError *)error
- (void)notificationReceived {
NSLog(@"Notification received");

if (notificationMessage)
if (notificationMessage && self.callbackId != nil)
{
NSMutableDictionary* message = [NSMutableDictionary dictionaryWithCapacity:4];
NSMutableDictionary* additionalData = [NSMutableDictionary dictionaryWithCapacity:4];
Expand Down

4 comments on commit 9f35486

@alexislg2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to fix #109

@slorber
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hahah I can't understand at all how this commit could fix that issue.

Adding a test condition would just make it "harder" to enter the if block no? :) weird

But I'm not an ObjC dev nor I took a good look at the code so maybe, will test that :)

@alexislg2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. I don't know the reason actually but when I install the plugin directly from the master branch, it's working correctly. Maybe another commit fixed it.

@Deathspike
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refer to my explanation in #117

Please sign in to comment.