Comment out @import directives #26
Closed
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TailwindCSS CLI 3.1 now has support for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleting the
@import "./phoenix.css";rule is not clear if you have not used Tailwind CLI before. Since installing this package is backwards-incompatible in this sense, I think it would be clearer to just comment out those lines, especially since the application will now not be able to use the classes in./phoenix.css. The user will have a clearer understanding of what is going on, even later on, if they do not overlook the changes and commit them straight into the repo.In comparison, the change to
assets/js/app.jskeeps the original behaviour for the application and is therefore not a "destructive" action.