fix negative tabindex handling when determining focusability #2919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves this issue. Basically, it seems the code was taking tabindex to mean something it doesn't. Negative tabindexes are programatically focusable, and they should be treated as such by isFocusable.
There's a secondary issue here which is that this code also seems to be considering all elements with positive tabindexes interactive, which is not what a positive tabindex means. I've chosen not to change that as it is outside the scope of my original issue, but I do think the
el.tabIndex > 0check should be removed as it is, in my opinion, a bug.