Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hal/imxrt106x: init enet PLL #355

Merged
merged 1 commit into from
Oct 3, 2024
Merged

hal/imxrt106x: init enet PLL #355

merged 1 commit into from
Oct 3, 2024

Conversation

julianuziemblo
Copy link
Contributor

@julianuziemblo julianuziemblo commented Sep 26, 2024 •
edited
Loading

Description

  • fix clk0 enable bit of enet PLL
  • add bypass during clock frequency change
  • initialize enet PLL
  • remove enet PLL deinitialization

Motivation and Context

enet driver for imxrt106x-evk needs this

Related: phoenix-rtos/phoenix-rtos-kernel#601 and phoenix-rtos/phoenix-rtos-kernel#595

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: armv7a7-imx6ull-evk, armv7m7-imxrt106x-evk.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@julianuziemblo julianuziemblo changed the title hal/imxrt: fix enet PLL hal/imxrt: init enet PLL Sep 26, 2024
@julianuziemblo julianuziemblo force-pushed the julianuziemblo/enet-imxrt106x-evk branch from 9211796 to 411c622 Compare September 27, 2024 11:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 27, 2024 •
edited
Loading

Unit Test Results

7 725 tests  ±0   7 010 ✅ ±0   37m 26s ⏱️ -9s
  445 suites ±0     715 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 962ab18. ± Comparison against base commit 6bb5dd6.

♻️ This comment has been updated with latest results.

@julianuziemblo julianuziemblo force-pushed the julianuziemblo/enet-imxrt106x-evk branch from 411c622 to bf77f1e Compare September 27, 2024 13:15
@julianuziemblo julianuziemblo marked this pull request as draft September 27, 2024 13:40
@julianuziemblo julianuziemblo mentioned this pull request Sep 30, 2024
Open
14 tasks
@julianuziemblo julianuziemblo force-pushed the julianuziemblo/enet-imxrt106x-evk branch 2 times, most recently from 255998b to f62a276 Compare October 1, 2024 10:52
@julianuziemblo julianuziemblo marked this pull request as ready for review October 1, 2024 11:58
@nalajcie
Copy link
Member

nalajcie commented Oct 1, 2024

the code looks good, please fix commit message:

  • the change is done only for imxrt106x, so please use it as a prefix
  • IMHO it's worth to describe WHY bypass enable is needed - either in the code as a comment and/or in the commit message body - eg something like /* enable bypass during clock frequency change */

@julianuziemblo julianuziemblo force-pushed the julianuziemblo/enet-imxrt106x-evk branch from f62a276 to 9634ef1 Compare October 3, 2024 07:37
@julianuziemblo julianuziemblo mentioned this pull request Oct 3, 2024
Open
14 tasks
@julianuziemblo julianuziemblo changed the title hal/imxrt: init enet PLL hal/imxrt106x: init enet PLL Oct 3, 2024
@julianuziemblo julianuziemblo force-pushed the julianuziemblo/enet-imxrt106x-evk branch 2 times, most recently from 5960eaf to 7a5da74 Compare October 3, 2024 12:35
nalajcie
nalajcie previously approved these changes Oct 3, 2024
View reviewed changes
hal/armv7m/imxrt/10xx/106x/imxrt.c Outdated Show resolved Hide resolved
@julianuziemblo
hal/imxrt106x: init enet PLL
962ab18 
- fix clk0 enable of enet PLL
- add bypass during clock frequency change
- init enet PLL
- remove enet PLL deinit

JIRA: RTOS-507
@julianuziemblo julianuziemblo force-pushed the julianuziemblo/enet-imxrt106x-evk branch from 7a5da74 to 962ab18 Compare October 3, 2024 13:04
@nalajcie nalajcie merged commit 420eca3 into master Oct 3, 2024
34 checks passed
@nalajcie nalajcie deleted the julianuziemblo/enet-imxrt106x-evk branch October 3, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalajcie nalajcie nalajcie approved these changes

@Darchiv Darchiv Awaiting requested review from Darchiv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julianuziemblo @nalajcie