Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_projects/(imx6ull, imxrt106x): Add config for iMX ENET driver #1134

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

julianuziemblo
Copy link
Contributor

@julianuziemblo julianuziemblo commented Aug 26, 2024

Description

Provides necessary default configuration for iMX RT106x/6ULL Ethernet driver.
This PR might not be passing some tests on armv7a7-imx6ull-evk without phoenix-rtos/phoenix-rtos-lwip#96.

Motivation and Context

Part of https://jira.phoenix-rtos.com/browse/RTOS-507.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: armv7a7-imx6ull-evk, armv7m7-imxrt106x-evk.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

Copy link

github-actions bot commented Aug 26, 2024

Unit Test Results

7 958 tests  ±0   7 416 ✅ ±0   40m 34s ⏱️ - 1m 47s
  470 suites ±0     542 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit c99b00c. ± Comparison against base commit d7b10b7.

♻️ This comment has been updated with latest results.

@julianuziemblo julianuziemblo force-pushed the julianuziemblo/enet-imxrt1064-evk branch from ad37b33 to 8f3f682 Compare August 26, 2024 12:18
@julianuziemblo julianuziemblo changed the title Config for iMX RT106x/6ULL ENET driver Add config for iMX ENET driver Aug 26, 2024
@julianuziemblo julianuziemblo force-pushed the julianuziemblo/enet-imxrt1064-evk branch from 8f3f682 to 99ea36b Compare August 26, 2024 12:21
@julianuziemblo julianuziemblo force-pushed the julianuziemblo/enet-imxrt1064-evk branch 3 times, most recently from bc5aa49 to e3f7b67 Compare September 10, 2024 11:54
@julianuziemblo julianuziemblo force-pushed the julianuziemblo/enet-imxrt1064-evk branch 3 times, most recently from c9351c1 to b6fa82a Compare September 17, 2024 11:41
@julianuziemblo julianuziemblo force-pushed the julianuziemblo/enet-imxrt1064-evk branch from b6fa82a to a9750ac Compare September 26, 2024 14:35
@julianuziemblo julianuziemblo force-pushed the julianuziemblo/enet-imxrt1064-evk branch from a9750ac to 197bbc8 Compare September 26, 2024 14:38
@julianuziemblo julianuziemblo changed the title Add config for iMX ENET driver _projects: Add config for iMX ENET driver Sep 26, 2024
@julianuziemblo julianuziemblo changed the title _projects: Add config for iMX ENET driver _projects/(imx6ull, imxrt106x): Add config for iMX ENET driver Sep 26, 2024
@julianuziemblo julianuziemblo force-pushed the julianuziemblo/enet-imxrt1064-evk branch 3 times, most recently from 10e1fea to 3050cca Compare October 7, 2024 14:42
@julianuziemblo julianuziemblo force-pushed the julianuziemblo/enet-imxrt1064-evk branch from 3050cca to 6a107ba Compare October 16, 2024 11:54

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [shellcheck] reported by reviewdog 🐶
Declare and assign separately to avoid masking return values. SC2155

export LWIPOPTS_DIR="$(pwd)/_projects/armv7a7-imx6ull-evk/lwip"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [shellcheck] reported by reviewdog 🐶
ERASE_SIZE appears unused. Verify use (or export if used externally). SC2034

ERASE_SIZE=$((16 * 4096)) # Rootfs disk erase block size (in bytes)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [shellcheck] reported by reviewdog 🐶
CLEANMARKER_SIZE appears unused. Verify use (or export if used externally). SC2034

CLEANMARKER_SIZE=$((0x10)) # JFFS2 cleanmarker size (in bytes)

@julianuziemblo julianuziemblo force-pushed the julianuziemblo/enet-imxrt1064-evk branch from 6a107ba to 50a6ea1 Compare October 16, 2024 11:58
@julianuziemblo julianuziemblo force-pushed the julianuziemblo/enet-imxrt1064-evk branch from 50a6ea1 to f734ee8 Compare December 10, 2024 10:37
julianuziemblo and others added 3 commits December 24, 2024 10:18
enet irq not inverted in the schematic

JIRA: RTOS-507
imx6ull-evk has 2x KSZ8081RNB instead of RNA

JIRA: RTOS-507
@julianuziemblo julianuziemblo force-pushed the julianuziemblo/enet-imxrt1064-evk branch from f734ee8 to c99b00c Compare December 24, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant