Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mmap: make interface posix compliant #471

Merged
merged 3 commits into from
Nov 9, 2023
Merged

mmap: make interface posix compliant #471

merged 3 commits into from
Nov 9, 2023

Conversation

badochov
Copy link
Contributor

@badochov badochov commented Nov 2, 2023 •
edited
Loading

JIRA: RTOS-665

Description

Adjust mmap to POSIX standard.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

@badochov badochov requested a review from agkaminski November 2, 2023 13:46
@badochov badochov marked this pull request as draft November 2, 2023 13:47
@badochov badochov force-pushed the badochov/mmap branch 2 times, most recently from 45be19f to f4ef11d Compare November 2, 2023 14:36
@badochov badochov mentioned this pull request Nov 2, 2023
Merged
13 tasks
@badochov badochov marked this pull request as ready for review November 2, 2023 14:56
@badochov
Copy link
Contributor Author

badochov commented Nov 2, 2023

Project branch with all changes to confirm it works:
phoenix-rtos/phoenix-rtos-project#909

github-actions[bot]
github-actions bot reviewed Nov 2, 2023
View reviewed changes
syscalls.c Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Nov 2, 2023
View reviewed changes
syscalls.c Outdated Show resolved Hide resolved
agkaminski
agkaminski reviewed Nov 3, 2023
View reviewed changes
proc/msg.c Outdated Show resolved Hide resolved
vm/map.c Outdated Show resolved Hide resolved
agkaminski
agkaminski reviewed Nov 3, 2023
View reviewed changes
syscalls.c Outdated Show resolved Hide resolved
@badochov badochov force-pushed the badochov/mmap branch 3 times, most recently from 92ffa92 to 2ac717c Compare November 8, 2023 13:35
agkaminski
agkaminski reviewed Nov 8, 2023
View reviewed changes
Copy link
Member

@agkaminski agkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpicks, otherwise LGTM

posix/posix.c Outdated Show resolved Hide resolved
vm/map.c Outdated Show resolved Hide resolved
@agkaminski agkaminski merged commit dcfb262 into master Nov 9, 2023
7 of 22 checks passed
@agkaminski agkaminski deleted the badochov/mmap branch November 9, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@agkaminski agkaminski agkaminski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@badochov @agkaminski