Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zynq7000: add platformctl for setting SD card pins #465

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Conversation

jmaksymowicz
Copy link
Contributor

This PR adds a platformctl command for selecting WP (write protect) and CD (card detect) pins for the SDIO controller.

Description

On Zynq 7000 platform the SDIO controller can handle signals from card detect and write protect pins of an SD card slot. Selection of which GPIO pins serve these functions is done through SDx_WP_CD_SEL register in slcr register bank. This PR adds a way of manipulating these registers consistent with other slcr registers.

Motivation and Context

Necessary for implementing a fully-featured SD Host Controller driver.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: armv7a9-zynq7000-zturn

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@github-actions
Copy link

github-actions bot commented Oct 19, 2023

Unit Test Results

5 734 tests  +13   5 095 ✔️ +12   28m 26s ⏱️ + 1m 49s
   311 suites +13      639 💤 +  1 
       1 files   ±  0          0 ±  0 

Results for commit 25a18c8. ± Comparison against base commit 9edeea5.

♻️ This comment has been updated with latest results.

Copy link
Member

@agkaminski agkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicks, otherwise looks good to me

hal/armv7a/zynq7000/zynq.c Outdated Show resolved Hide resolved
hal/armv7a/zynq7000/zynq.c Outdated Show resolved Hide resolved
include/arch/zynq7000.h Outdated Show resolved Hide resolved
@agkaminski agkaminski merged commit d19e97a into master Oct 20, 2023
30 checks passed
@agkaminski agkaminski deleted the RTOS-630 branch October 20, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants