dummyfs: memory-related fixes #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: remove unneeded chunk properly. Fixes phoenix-rtos/phoenix-rtos-project#169
- deleted dirents for dummyfs root dir were never freed - fixed memory leaks in error paths - fixed ERRNO value Related to phoenix-rtos/phoenix-rtos-project#169
agkaminski
approved these changes
Aug 19, 2021
| @@ -35,6 +35,8 @@ int dir_find(dummyfs_object_t *dir, const char *name, oid_t *res) | |||
| if (e == NULL) | |||
| return -ENOENT; | |||
|
|
|||
| dirname = strdup(name); | |||
There was a problem hiding this comment.
Yeah, I think dummyfs needs some careful review. I believe the current approach (always trying to realloc chunks) may result in performance slowdowns (hidden memcpy in realloc implementation).
Also - we need at least some basic functionality checks for file systems (this error was triggered every time a file was truncated to 0 - so for example deleted). Unfortunately we can't test dummyfs on ia32-generic due to phoenix-rtos/phoenix-rtos-project#114)
There was a problem hiding this comment.
I agree. I think that dummyfs makes writes at NULL pointer on NOMMU targers - we found traces of it only when dummyfs has been started...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Also: remove unneeded chunk properly.
Motivation and Context
Fixes phoenix-rtos/phoenix-rtos-project#169
Types of changes
How Has This Been Tested?
imx6ull.Checklist:
Special treatment