Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ext2: add compatibility with libstorage #110

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

jmaksymowicz
Copy link
Contributor

Modified libext2 to make it compatible with libstorage. This will make the filesystem driver compatible with storage device drivers based on libstorage.

Description

Message handling performed by the libext2_handler was split into separate functions that are compatible with the libstorage API for file systems.

Compatibility with pc-ata storage driver (that uses the current API for handling ext2 filesystems) was not affected.

Additionally, length checks on file names were added (previously name lengths could cause integer overflow).

Motivation and Context

ext2 filesystem would be useful for data exchange using SD cards as ext2 can be easily mounted on many host PC operating systems.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: ia32-generic-qemu, armv7a9-zynq7000-zturn

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

ext2/ext2.h Outdated Show resolved Hide resolved
add length checks on paths
JIRA: RTOS-630
@github-actions
Copy link

Unit Test Results

5 949 tests  +215   5 296 ✔️ +201   30m 19s ⏱️ + 3m 1s
   325 suites +  14      653 💤 +  14 
       1 files   ±    0          0 ±    0 

Results for commit 350261d. ± Comparison against base commit c4fd8de.

@agkaminski agkaminski merged commit c56434f into master Nov 2, 2023
@agkaminski agkaminski deleted the ext2-libstorage branch November 2, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants