Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for gr740 and generic flash driver #532

Merged
merged 5 commits into from
Jan 28, 2025

Conversation

lukileczo
Copy link
Member

@lukileczo lukileczo commented Jan 21, 2025

Description

  • adapt grlib-multi to gr740 target
  • implement generic flash driver for GRLIB based targets (GR712RC, GR740, NOEL-V)

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

Copy link
Member

@agkaminski agkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks. For the future - it should be possible to share even more code between the drivers, especially driver init/deinit share quite a lot of common parts

storage/flashdrv/drv/grlib-ftmctrl/flashdrv.c Outdated Show resolved Hide resolved
storage/flashdrv/drv/grlib-spimctrl/flash.c Outdated Show resolved Hide resolved
storage/flashdrv/drv/grlib-spimctrl/flashdrv.c Outdated Show resolved Hide resolved
@lukileczo lukileczo force-pushed the lukileczo/new-flashdrv branch from 35142f4 to 8d185fa Compare January 28, 2025 09:55
@lukileczo lukileczo force-pushed the lukileczo/new-flashdrv branch from 8d185fa to 84d2b6a Compare January 28, 2025 09:56
@agkaminski agkaminski merged commit f2679f4 into master Jan 28, 2025
14 of 27 checks passed
@agkaminski agkaminski deleted the lukileczo/new-flashdrv branch January 28, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants