-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for gr740 and generic flash driver #532
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA: RTOS-883
JIRA: RTOS-883
JIRA: RTOS-883
14 tasks
lukileczo
force-pushed
the
lukileczo/new-flashdrv
branch
from
January 21, 2025 15:17
1a2871c
to
f5dafd1
Compare
This was referenced Jan 21, 2025
Merged
lukileczo
force-pushed
the
lukileczo/new-flashdrv
branch
2 times, most recently
from
January 21, 2025 15:50
88f5d33
to
35142f4
Compare
agkaminski
reviewed
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicks. For the future - it should be possible to share even more code between the drivers, especially driver init/deinit share quite a lot of common parts
lukileczo
force-pushed
the
lukileczo/new-flashdrv
branch
from
January 28, 2025 09:55
35142f4
to
8d185fa
Compare
JIRA: RTOS-951
lukileczo
force-pushed
the
lukileczo/new-flashdrv
branch
from
January 28, 2025 09:56
8d185fa
to
84d2b6a
Compare
agkaminski
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
grlib-multi
to gr740 targetMotivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment