Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom ignore matcher #7

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

Blissful89
Copy link
Contributor

Changes

Description

I added a way to ignore TODO lines matching a certain ignore matcher. This would be simple to use. I wanted it, such that I can ignore TODOs in my code that are linked to issues.

Example

custom_ignore_matcher: "my-issue-website" would ignore // TODO - http://my-issue-website

@Blissful89
Copy link
Contributor Author

@rehlma Hi. just a kind poke to check if this PR has been noticed 😃 .

@rehlma
Copy link
Contributor

rehlma commented Nov 20, 2024

I'm sorry but I actual did not notice 😃. Good idea to add an ignore matcher 👍
Did you run npm run all to make sure the formatting is right?
If yes we need to check why the CI is failing.

@rehlma
Copy link
Contributor

rehlma commented Nov 20, 2024

I just checked what the issue is here.

  1. There are two lint warnings
/Users/pr_todo_checker/src/todo-finder.ts
  183:43  error  Missing return type on function  @typescript-eslint/explicit-function-return-type
  198:23  error  Redundant Boolean call           no-extra-boolean-cast
  1. You need to run npm run bundle (it's also part of npm run all) to build the actual JS code in /dist.

For me this fixed the failing Check dist check.

@Blissful89
Copy link
Contributor Author

Blissful89 commented Nov 20, 2024

@rehlma ran it as asked. Apologies for not running the script earlier.

@rehlma
Copy link
Contributor

rehlma commented Nov 20, 2024

No worries thanks for contributing!

And as you noticed already you need to run the bundle command after code changes like fixing the lint issue.
Maybe I should add a contribute.md 😃

I'll create a new release 👍

@rehlma rehlma merged commit c0adc82 into phntmxyz:main Nov 20, 2024
@Blissful89 Blissful89 deleted the feature/add-custom-ignore-matcher branch November 20, 2024 14:56
@rehlma
Copy link
Contributor

rehlma commented Nov 20, 2024

It's released. If you're using the moving tag v1 it should use the new version now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants