fix: resolve issues with scoped classes in PHAR #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch makes several changes to PHAR creation to resolve the following issues: - Generated local configuration files were receiving the autogenerated namespace as a prefix to the configuration. This is likely a bug in Box and/or PHP-Scoper, but it's possible to work around it (I chose `implode()` with a list of lines, as any nowdoc or heredoc triggered the injection for me). - Configuration files reference provider classes. This led to problems when scoping as those classes then could not be found. I have added php-scoper whitelist entries for the specified classes to ensure that configuration can be used and not lead to errors. - Once php-scoper configuration was introduced, I started seeing warnings thrown around polyfill classes we use. I have updated the php-scoper configuration to whitelist global classes. In my local testing, all operations that previously did not work under the PHAR now work. Fixes #81 Fixes #82 Signed-off-by: Matthew Weier O'Phinney <[email protected]>
weierophinney
added a commit
that referenced
this pull request
Sep 14, 2020
Signed-off-by: Matthew Weier O'Phinney <[email protected]>
|
I can also confirm; it works now locally with the PHAR from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes several changes to PHAR creation to resolve the following issues:
Generated local configuration files were receiving the autogenerated namespace as a prefix to the configuration.
This is likely a bug in Box and/or PHP-Scoper, but it's possible to work around it (I chose
implode()with a list of lines, as any nowdoc or heredoc triggered the injection for me).Configuration files reference provider classes.
This led to problems when scoping as those classes then could not be found.
I have added php-scoper whitelist entries for the specified classes to ensure that configuration can be used and not lead to errors.
Once php-scoper configuration was introduced, I started seeing warnings thrown around polyfill classes we use.
I have updated the php-scoper configuration to whitelist global classes.
In my local testing, all operations that previously did not work under the PHAR now work.
Fixes #81
Fixes #82