Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull request on master from forked release branch #135

Closed
wants to merge 7 commits into from
Closed

Pull request on master from forked release branch #135

wants to merge 7 commits into from

Conversation

andrewscaya
Copy link
Contributor

This release:

  1. Updates all references to the deprecated Zend\Stdlib\Hydrator classes.
  2. Replaces all occurrences of the EventManager's triggerUntil method (deprecated) with its trigger method,
  3. Modifies a method declaration for consistency,
  4. Updates the version numbers of the module's required components and adds a requirement for the Zend Hydrator component,
  5. Adds PHP 5.5, 5.6 and 7.0 as supported versions and removes PHP 5.3 and 5.4 from the support matrix,
  6. Modifies a few unit tests in order to correct a failed test (new namespace for the Zend Hydrator classes) and a couple of errors concerning a missing argument to the ControllerManager's constructor and,
  7. Corrects a few code styling issues.

@andrewscaya
Updated all references to the deprecated Zend\Stdlib\Hydrator classes.
2b0f6c4
@andrewscaya
Modified a method declaration for consistency.
2da2c66
@andrewscaya
Replaced all occurrences of the EventManager's triggerUntil method (d…
99d11c9 
…eprecated) with its triggerEventUntil method (forwards compatible).
@andrewscaya
Updated the version numbers of the module's required components and a…
d96e679 
…dded a requirement for the Zend Hydrator component.
@andrewscaya
Added PHP 5.5, 5.6 and 7.0 as supported versions and removed PHP 5.3 …
bce1022 
…and 5.4 from the support matrix.
@andrewscaya
Modified a few unit tests in order to correct a failed test (new name…
f7e25b1 
…space for the Zend Hydrator classes) and a couple of errors concerning a missing argument to the ControllerManager's constructor.
@andrewscaya
Corrected a few code styling issues.
fb87697
weierophinney
weierophinney reviewed May 26, 2016
View reviewed changes
src/PhlyRestfully/ResourceController.php
@@ -389,7 +389,7 @@ public function delete($id)
return $response;
}

public function deleteList()
public function deleteList($data = [])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be a required parameter, as zend-mvc made it required in 2.2 or 2.3, IIRC. I'll write a test to check, and, of so, update it during merge.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot that removing arguments follows the LSP, so this works fine.

@weierophinney weierophinney added this to the 2.3.0 milestone May 26, 2016
@weierophinney weierophinney self-assigned this May 26, 2016
weierophinney added a commit that referenced this pull request May 26, 2016
@weierophinney
Merge pull request #135 from andrewscaya/release
6422082 
Pull request on master from forked release branch
weierophinney added a commit that referenced this pull request May 26, 2016
@weierophinney
Added CHANGELOG for #135 and 2.3.0
d534e90
weierophinney added a commit that referenced this pull request May 26, 2016
@weierophinney
Merge branch 'feature/135' into develop
86bf861 
Close #135
Fixes #134
Fixes #133
Fixes #132
@weierophinney
Copy link
Contributor

Merged to develop for release with 2.3.0 (which will be within the next hour or so)

@weierophinney weierophinney mentioned this pull request May 26, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@weierophinney weierophinney

Labels
enhancement
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewscaya @weierophinney