check OS to use appropriate program to open files in rga-fzf #260
Conversation
| let (cmd, pdf_cmd) = match env::consts::OS { | ||
| "macos" => ("open", "open -a Preview.app"), // use native Preview for macOs | ||
| "linux" => ("xdg-open", "evince"), // use evince for linux | ||
| &_ => ("", ""), |
There was a problem hiding this comment.
I haven't personally verified this, but start appears to be relevant command on Windows. Supposedly when passed a file as its sole argument it behaves the same as double-clicking the file in explorer.exe, namely opening the file in the associated default program.
There was a problem hiding this comment.
Thanks for the info! I did some digging around that and apparently start doesn’t work consistently across shells in Windows. This info might be outdated since the comment talking about this is from 2018.
Also, in the doc you sent about start it says you can run non-executable files through their file association by typing the name of the file as a command. A little bit of search led me to this two articles from last year which claim the same thing: howtogeek article, windows loop article.
I might try to personally test these and see which alternative is best with a Windows VM or a Windows Docker container.
There was a problem hiding this comment.
Also, in the doc you sent about
startit says you can run non-executable files through their file association by typing the name of the file as a command.
Thinking out loud: I wonder if that is implemented at the level of cmd.exe/PowerShell or somewhere deeper. If the former, it might be easier to look at how other Rust programs are solving this than trying to reason it from first principles…
There was a problem hiding this comment.
Finally researched this a bit more. It looks like start is a built-in in both cmd.exe and Windows variants of PowerShell, not a standalone tool that can be trivially executed. The standard approach (see CPython's implementation as an example) seems to be to spin out a shell process to run start.
However, it might be worth just pulling in a dependency like open rather than implement this directly. There appear to be some odd edge cases that I'd rather not have to keep track of and handle, e.g. Byron/open-rs#73.
There was a problem hiding this comment.
That said, I'd personally be in favor of merging this PR as-is and leaving the Windows implementation as a todo. master currently lacks Windows support, so this wouldn't constitute a regression in any way.
@phiresky Any opinions?
Replace hardcoding
evinceto open pdfs andxdg-opento open other files when usingrga-fzfuse those if the OS is Linux, and useopenif the OS is macOs. If the OS is neither macOs nor Linux, it fails to open. I didn’t add an option for Windows because I’m not familiar enough with it to suggest a program.This is intended to fix #240 and #253 by checking the OS before running
xdg-openandevince.