Add .kra (Krita documents) to zip adapter #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@duxovni Mind rebasing? |
|
Done!
…On May 8, 2024 7:49:22 PM EDT, Joseph LaFreniere ***@***.***> wrote:
@duxovni Mind rebasing?
--
Reply to this email directly or view it on GitHub:
#208 (comment)
You are receiving this because you were mentioned.
Message ID: ***@***.***>
|
lafrenierejm
approved these changes
May 11, 2024
|
seems fine though I'm not sure how useful searching krita files is? I'd expect them to only / mostly just have picture / vector data. Note that every file search takes up compute time so enabling this might have a negative impact esp. since krita files are probably large. Yes, being able to configure the extensions of the zip adapter sounds useful if someone wants to make a PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Krita documents are also zip archives, but the accurate matcher doesn't seem to be recognizing them properly. More generally, it'd be nice to have the ability to configure extra associations of file extensions to integrated adapters, rather than needing a patch for every new filetype that's actually a zip archive.