Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .als file support #185

Merged
merged 3 commits into from
Sep 25, 2023
Merged

Add .als file support #185

merged 3 commits into from
Sep 25, 2023

Conversation

Neved4
Copy link
Contributor

@Neved4 Neved4 commented Sep 21, 2023

Closes #184.

@Neved4 Neved4 changed the title Add .als file support Add .als file support Sep 22, 2023
@phiresky
Copy link
Owner

@lafrenierejm

pre-commit-run> nixfmt...................................................................Passed
pre-commit-run> rustfmt..................................................................Passed
pre-commit-run> typos....................................................................Failed
pre-commit-run> - hook id: typos
pre-commit-run> - exit code: 2
pre-commit-run> error: `als` should be `also`
pre-commit-run>   --> src/adapters/decompress.rs:11:33
pre-commit-run>    |
pre-commit-run> 11 | static EXTENSIONS: &[&str] = &["als", "bz2", "gz", "tbz", "tbz2", "tgz", "xz", "zst"];
pre-commit-run>    |                                 ^^^
pre-commit-run>    |
pre-commit-run> error: `als` should be `also`
pre-commit-run>   --> src/adapters/decompress.rs:65:14
pre-commit-run>    |
pre-commit-run> 65 |             "als" | "gz" | "tgz" => gz(inp),
pre-commit-run>    |              ^^^
pre-commit-run>    |

please disable spell checking?

@lafrenierejm
Copy link
Contributor

please disable spell checking?

I have raised Neved4#1 against @omnv's branch to fix the CI error.

Configure `typos` to accept "als" as correct spelling
@phiresky
Copy link
Owner

@lafrenierejm I'm not really convinced that spell checking string literals is more useful than it is annoying but sure I guess

@phiresky phiresky merged commit 6d32bb7 into phiresky:master Sep 25, 2023
@lafrenierejm
Copy link
Contributor

@lafrenierejm I'm not really convinced that spell checking string literals is more useful than it is annoying but sure I guess

@phiresky We can definitely remove typos from list of pre-commit and CI checks if you'd like. I also opened crate-ci/typos#832 just now; if that issue gets traction then we might be able to continue using typos but with a lower rate of false-positives. I am fine either way, so just LMK if you'd prefer to remove typos entirely!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support .als files
3 participants