Fix pretty raw_html with encoded text (#525)

* Fix pretty raw_html with encoded text * Fix test on html5ever
philss · Jan 12, 2024 · 1489f5f · 1489f5f
1 parent b01543a
commit 1489f5f
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/lib/floki/raw_html.ex b/lib/floki/raw_html.ex
@@ -219,10 +219,13 @@ defmodule Floki.RawHTML do
   defp leftpad(:noop), do: ""
   defp leftpad(%{pad: pad}), do: pad
 
-  defp leftpad_content(:noop, string), do: string
+  defp leftpad_content(:noop, content), do: content
 
-  defp leftpad_content(padding, string) do
-    trimmed = String.trim(string)
+  defp leftpad_content(padding, content) do
+    trimmed =
+      content
+      |> IO.iodata_to_binary()
+      |> String.trim()
 
     if trimmed == "" do
       ""

diff --git a/test/floki_test.exs b/test/floki_test.exs
@@ -484,6 +484,10 @@ defmodule FlokiTest do
         <div class="content">
           <span>
             <div>
+              encoded content
+              &
+              '
+              "
 
       <span>
                 <small>
@@ -517,6 +521,10 @@ defmodule FlokiTest do
                <div class="content">
                  <span>
                    <div>
+                     encoded content
+                     &amp;
+                     &#39;
+                     &quot;
                      <span>
                        <small>
                          very deep content