Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][refactor] Attach methods to prototype instead of object. #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cirosantilli
Copy link

Doing:

  • @func = -> inside of the constructor attaches methods to objects, which uses extra memory if there are multiple objects
  • func: -> attaches to .prototype, so one per class.

Since it is more efficient, it is also more common, and therefore easier to identify the instance methods.

Also requires using @user instead of _user closure variable, which is good as it makes it clear what is an instance variable and what is a local one.

If good I will do this for every class.

Only the 2 currently failing tests fail like before this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant