Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload base64 string data does not work #69

Open
Kedrigern opened this issue Oct 6, 2014 · 1 comment
Open

Upload base64 string data does not work #69

Kedrigern opened this issue Oct 6, 2014 · 1 comment

Comments

@Kedrigern
Copy link

Hello,

upload binary data (represented as base64 encoded string) does not work. Minimal working example: http://jsfiddle.net/keddie/jgyroh4t/
Data in repository are base64 string, not binary result.

For testing I am using this litle png pic:

iVBORw0KGgoAAAANSUhEUgAAAAUAAAAFCAIAAAACDbGyAAAACXBIWXMAAAsTAAALEwEAmpwYAAAA
B3RJTUUH3goGFQosWeF1cAAAAB1pVFh0Q29tbWVudAAAAAAAQ3JlYXRlZCB3aXRoIEdJTVBkLmUH
AAAAPElEQVQI1wXBgQGAMAgEsXvAdlgHc0YVHxP1ddIvbpTUKvqhb2wigGI8NrYY4quRyESAiCgd
awQTkNT+AcRpGCXzXr3kAAAAAElFTkSuQmCC`

Tested at latest version.
Kedrigern added a commit to Kedrigern/octokit.js that referenced this issue Oct 11, 2014
@Kedrigern
Fix upload of base64 encoded files.
06f6dc4 
Fix philschatz#69
@Kedrigern Kedrigern mentioned this issue Oct 11, 2014
Open
@aaron-comyn aaron-comyn mentioned this issue Oct 12, 2015
Closed
@insaneshadowzaman
Copy link

Is there any update about this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Kedrigern @insaneshadowzaman