Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to make this work with an upstream #8

Closed
plessbd opened this issue Mar 2, 2016 · 5 comments
Closed

How to make this work with an upstream #8

plessbd opened this issue Mar 2, 2016 · 5 comments

Comments

@plessbd
Copy link

plessbd commented Mar 2, 2016

So I have a question that I have not found the answer to.

This might be "support forked Pull Requests" and I just dont know it

I have my fork of a private repository I do a pull request to the upstream repo. Is there a way for me to see the pull request comments if I only have my repo checked out?

as an example

git remote -v

coworker1 [email protected]/coworker1/repo.git (push)
coworker1 [email protected]/coworker1/repo.git (fetch) 
origin [email protected]/plessbd/repo.git (push)
origin [email protected]/plessbd/repo.git (fetch) 
upstream [email protected]/myorg/repo.git (push)
upstream [email protected]/myorg/repo.git (fetch) 

I am willing to help test this out if it is something you are working towards, I have never worked on an atom plugin before though

@philschatz
Copy link
Owner

Ah yes, that is the "support forked Pull Requests" item. One challenge is that it is unclear which GitHub repository to search for Pull Requests data (since there is no information in the local git repository).

I can probably search for Pull Requests in the current repository (that is what happens currently) as well as the original repository since GitHub does provide a parent: field when getting information about a repository (Example: search for parent: in https://api.github.com/repos/philschatz/tree-view ).

I hope that helps!

@plessbd
Copy link
Author

plessbd commented Mar 2, 2016

It does, explains why I cant find anything :)

What about looking for the upstream remote as a way to know where to look?

That seems to be the "standard" https://help.github.com/articles/syncing-a-fork/ way of referencing the parent.
[edit]
Or maybe a configuration that allows the user to set the upstream remote name that they want to use?

@plessbd plessbd changed the title [QUESTION] How to make this work How to make this work with an upstream Mar 2, 2016
@philschatz
Copy link
Owner

#11 should work. Are you still interested in testing? It does not use the upstream field in the git config because I do not know if that information is available to atom. But it does use the parent repo if this repo was forked in GitHub.

@plessbd
Copy link
Author

plessbd commented Apr 12, 2016

I am willing to test it. Sorry it took so long to reply.

What do I need to do? Currently I cannot see anything related to the pull request

@cbrownrt
Copy link

cbrownrt commented Jun 9, 2016

This would be a big help, since we are using GitHub Flow, but I can't even get it to work on PRs within a repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants