Prevents atom theme switch on the fly

[dac09]

Hi,

Thanks for creating this - I haven't gotten it to work yet with PRs on private repos (I did add the github key) - but I found a different issue.

Unfortunately I don't really have any logs to attach (no errors thrown) But after pain-stakingly disabling each package, I found that this package some how stops atom from changing themes without a restart. It also seems to block enable/disable of packages. i.e. You change the theme / disable some package, then need to reload the window to see the change.

Atom version 1.6.2, here's by list of installed packages
[email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected]

Thanks

[philschatz]

Thanks for reporting! Is the private repository hosted on github.com or using GitHub Enterprise?

Also, the theme-changing requiring a restart may be because the tree-view package does not have a nice way to add icons (the blue comment icon plus the number of comments) on its own so I had to manually add them in.

It is a hacky solution, so I created atom/tree-view#658 which makes it so any plugin can add additional icons but it looks like it may take a while to get merged (feel free to comment on the PR to help get it in faster 😄 )

[dac09]

Hi,

It's a private repository on github.com - originally I had a remote called upstream setup as this issue mentions: #8.

Just tried it with with a pull request to origin - seems to show indicators on the tree-view (https://www.dropbox.com/s/hkxvxdvlyaay397/Screenshot%202016-04-02%2022.38.02.png?dl=0) but nothing on the code itself.

Thanks,
Danny

*Update: * Looks like if you have the file open, and reload atom, it shows up with the comments on the gutter. I've seen this behaviour happen with https://github.com/smashwilson/merge-conflicts. If you don't have the file open when the editor loads, comments don't show up.