Skip to content
This repository has been archived by the owner on Jan 16, 2025. It is now read-only.

Commit

Permalink
fix: remove deprecated use of S3 ACLs (#3222)
Browse files Browse the repository at this point in the history
* fix: Remove deprecated use of S3 ACLs

ACLs were disabled by default in April 2023:
https://aws.amazon.com/about-aws/whats-new/2022/12/amazon-s3-automatically-enable-block-public-access-disable-access-control-lists-buckets-april-2023/

As we don't use ACLs, it's simplest to configure the bucket to not use
them, which is the new recommended approach.

Fixes #3202.

* terraform fmt
  • Loading branch information
alexjurkiewicz authored Apr 28, 2023
1 parent 54575fd commit bf4cea8
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions modules/runner-binaries-syncer/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,11 @@ resource "aws_s3_bucket" "action_dist" {
tags = var.tags
}

resource "aws_s3_bucket_acl" "action_dist_acl" {
resource "aws_s3_bucket_ownership_controls" "this" {
bucket = aws_s3_bucket.action_dist.id
acl = "private"
rule {
object_ownership = "BucketOwnerEnforced"
}
}

resource "aws_s3_bucket_lifecycle_configuration" "bucket-config" {
Expand Down

0 comments on commit bf4cea8

Please sign in to comment.