Add Leaflet backend to enable custom map providers e.g. OpenStreetMap #94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all: Thanks for the great Django plugin! Extending your code was straight forward, although I have never written custom Django widgets myself.
The existing JS code was not modified, to maintain backward compatibility. Instead there was a new
settings.py
parameter introduced:GEOPOSITION_BACKEND
. Only the JS and CSS files needed for the specified backend will be loaded. Whilegoogle
is the default backend, there is no need for existing users to change their configuration files.To use the new backend add
GEOPOSITION_BACKEND = 'leaflet'
tosettings.py
. This will load Leaflet to display the default OpenStreetMap. As Leaflet is provider agnostic, you could use any other map provider from the following list: http://leaflet-extras.github.io/leaflet-providers/previewHere is an example configuration displaying satellite imagery with some more custom map options:
If you are OK with the proposed architecture, I'll add documentation and examples to the readme accordingly.