Updated to support Django 2.0 #103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @Romamo , it worked for me on Django 2.0.3 👍 |
|
Thanks @Romamo , it worked for me too on Django 2.0.7 👍 |
|
Thanks, @Romamo !!! It's working for me now with Django==2.1.1 For those who want to use Romamo's fix as a dependency, add this to your |
Benbb96
reviewed
Sep 28, 2018
| @@ -33,7 +33,7 @@ if (jQuery != undefined) { | |||
| $mapContainer = $('<div class="geoposition-map" />'), | |||
| $addressRow = $('<div class="geoposition-address" />'), | |||
| $searchRow = $('<div class="geoposition-search" />'), | |||
| $searchInput = $('<input>', {'type': 'search', 'placeholder': 'Start typing an address …'}), | |||
| $searchInput = $('<input>', {'type': 'text', 'placeholder': 'Start typing an address …'}), | |||
| $latitudeField = $container.find('input.geoposition:eq(0)'), | |||
| $longitudeField = $container.find('input.geoposition:eq(1)'), | |||
| latitude = parseFloat($latitudeField.val()) || null, | |||
There was a problem hiding this comment.
For the French people who want to use this library, the value of the $latitudeField will have a coma so I needed to replace by a dot like so latitude = parseFloat($latitudeField.val().replace(',', '.')). And do the same for the longitude.
Otherwise, the value was truncated to an integer.
|
When will this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.