Sort and simplify #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Abfragen in getMyProjectIds mit einem Join verbessert werden könnten.
contained an invalud queue (projecte_assigned does not have a 'end' column) and is not used anywhere within collabtive.
| $sel = $conn->prepare("SELECT projekte.ID | ||
| FROM projekte LEFT join projekte_assigned | ||
| ON projekte.ID=projekte_assigned.projekt | ||
| WHERE user=? AND status=$status |
There was a problem hiding this comment.
im Prinzip könnte man die query auch direkt ohne prepare abfeuern, der Typ von user wird ja vorher geprüft, so dass da keine insertion möglich ist.
|
muss ich mir ueber die implikationen noch gedanken machen. dieses ganze sortierungsissue muesste mal konsistent ueberdacht werden *vermut |
…-simplify Conflicts: include/class.project.php
|
werde ich die tage mergen. werde allerdings die sortierreihenfolge ändern. |
Conflicts: include/class.project.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ich habe festegestellt, dass getMyProjectIds nicht verwendet wird, und das getMyProjects viele SQL-Abfragen in einer Schleife macht, die mit einer einfachen Abfrage zusammengefasst werden können.
Falls ihr meinen Code übernehmt, achtet darauf, dass ich Sortierung nach Projektnamen und nicht nach ID verwende.