Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install vimium on Firefox from source code #2965

Open
KyleGrains opened this issue Feb 22, 2018 · 4 comments
Open

Install vimium on Firefox from source code #2965

KyleGrains opened this issue Feb 22, 2018 · 4 comments

Comments

@KyleGrains
Copy link

I have compiled the source code using CoffeeScript, and installed it as extension on Chrome.

But after I zipped the compiled code in xpi format, dragged it to about:addons page on Firefox Quantum, the warning dialog said the package is damaged. How can I install it on Firefox in the correct way?

I am looking at the Issue #2962, and trying it on Firefox by the way.
@smblott-github
Copy link
Collaborator

On Firefox, go to about:debugging and click "Load Temporary Add-on":

image

I usually pick the manifest file from the Vimium directory.

@KyleGrains
Copy link
Author

image
It seems something's wrong with the webExtension manifest.

@smblott-github
Copy link
Collaborator

You can take that property out of the manifest for testing (_comment).

Previously Firefox and Chrome just ignored it. I'll take it out.

It's unfortunate, because it's really useful having that comment there.

@KyleGrains
Copy link
Author

I have deleted that line in manifest, and it is installed now.
The find mode seems working right on Mac OS, I will try it on Windows later.

smblott-github added a commit to smblott-github/vimium that referenced this issue Feb 22, 2018
@smblott-github
Remove _comment from manifest.
fed487f 
Apparently some versions of Firefox are baulking at unreconised
properties in the manifest.

See: philc#2965 (comment).

Mention @KyleLS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smblott-github @KyleGrains