Skip to content

Commit

Permalink
Do not search in all frames.
Browse files Browse the repository at this point in the history
Chrome has never searched in all frames, so this is no loss.

However, find on Firefox Quantum is now broken with the "all frames"
flag set.

Fixes #2962.

H/t: @gdh1995 (#2962 (comment)).
  • Loading branch information
smblott-github committed Feb 23, 2018
1 parent 4d7730f commit 1bfe474
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion content_scripts/mode_find.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ class FindMode extends Mode
document.removeEventListener("selectionchange", @restoreDefaultSelectionHighlight, true)

try
result = window.find(query, options.caseSensitive, options.backwards, true, false, true, false)
result = window.find(query, options.caseSensitive, options.backwards, true, false, false, false)
catch # Failed searches throw on Firefox.

# window.find focuses the |window| that it is called on. This gives us an opportunity to (re-)focus
Expand Down

0 comments on commit 1bfe474

Please sign in to comment.