Refactor exception code into new interrupts module
#475
Conversation
| = help: have you added the `#[macro_use]` on the module/import? | ||
| ``` | ||
|
|
||
| And this error occurs because the `print!` and `println!` macros we created in the `vga_buffer` _must be defined_ before we use them. This is one case where import order matters in Rust. We can easily fix this by ensuring the order of our imports places the macros first: |
There was a problem hiding this comment.
Isn't the problem also that macro_use is missing?
There was a problem hiding this comment.
Unfortunately no, it really is the order of the imports. Just adding #[macro_use] by itself will still result in the following error:
error: cannot find macro `print!` in this scope
--> src/interrupts.rs:52:5
|
52 | print!(".");
| ^^^^^
|
= help: have you added the `#[macro_use]` on the module/import?
Due to the way that Rust compiles macros, they must be defined first before they're used.
There was a problem hiding this comment.
There was a problem hiding this comment.
I meant that we need to change the order and add macro_use (i.e. the macro_use was not there before, so we should probably mention in the text that we need to add it).
There was a problem hiding this comment.
Ah right! Sorry I misunderstood. I'll add that in now. 🙂
There was a problem hiding this comment.
I went for something more verbose because I think it's clearer for those new to Rust - this is a case which can be confusing for some.
| pub mod serial; | ||
| ``` | ||
|
|
||
| Now we can use our `print!` and `println!` macros in `interrupts.rs`. If you'd like to know more about the ins and outs of macros and how they differ from functions [you can find more information here](in-depth-rust-macros). |
There was a problem hiding this comment.
| Now we can use our `print!` and `println!` macros in `interrupts.rs`. If you'd like to know more about the ins and outs of macros and how they differ from functions [you can find more information here](in-depth-rust-macros). | |
| Now we can use our `print!` and `println!` macros in `interrupts.rs`. If you'd like to know more about the ins and outs of macros and how they differ from functions [you can find more information here][in-depth-rust-macros]. |
Fix markdown link syntax (with parantheses it links to ./in-depth-rust-macros).
| @@ -403,7 +442,7 @@ static BREAKPOINT_HANDLER_CALLED: AtomicUsize = AtomicUsize::new(0); | |||
| #[cfg(not(test))] | |||
| #[no_mangle] | |||
| pub extern "C" fn _start() -> ! { | |||
| init_idt(); | |||
| blog_os::interrupts::init_idt(); | |||
There was a problem hiding this comment.
This isn't correct. The test works by creating an own IDT that references the new breakpoint_handler function. See https://github.com/phil-opp/blog_os/blob/master/src/bin/test-exception-breakpoint.rs.
The problem is that we don't show the full file because it would be too long. But I think we need to rework which parts we show and which we don't.
There was a problem hiding this comment.
I opened https://github.com/acheronfail/blog_os/pull/3 against your branch to fix this.
There was a problem hiding this comment.
Awesome! I think renaming it to init_test_idt() was a good idea. 🔥 💯
Clarify that the exceptions tests use their own IDT
|
Awesome, thanks a lot for the quick updates! |
phil-opp
added
the
relnotes
phil-opp
changed the title
interrupts module
As discussed in #473 and https://github.com/acheronfail/blog_os/pull/1/files.
This PR re-writes the 6th and 7th posts so that all exception related code lives in
src/interrupts.rs.