TypeError message at startup on iPhone from this plugin

[claremacrae]

As discussed in Discord - inside-mobile:

On some phones, this message gets displayed at startup:

Text:

TypeError: undefined is not an object (evaluating
'this.app.commands.commands[mapped.commandID].icon = mapped.iconID')

@_quack figured out the only plugin with iconID in their vault was this one, and I was then able to confirm that when I just turn off this one plugin, that message disappears for me too.

Searching the code, it looks like it's here:

obsidian-advanced-toolbar/src/main.ts

Lines 151 to 160 in c709a7d

	injectIcons() {
	this.settings.mappedIcons.forEach(mapped => {
	try {
	//@ts-ignore
	this.app.commands.commands[mapped.commandID].icon = mapped.iconID;
	} catch (error) {
	new Notice(error);
	}
	});
	}

The //@ts-ignore is interesting. Does it suggest that there is a possible error case that is being ignored?

It would be helpful if there was a meaningful error message issued, like what the problem command was...

[QuaCKeReD]

As an additional the above, this breaks Obsidian on my iPhone 13 Pro - on both app store and insider versions

App starts up, loads everything, freezes, does same al over again, then goes to a grey screen...

EDIT: this isnt cause of break - have managed to recover iPhone operation and even with this error now it doesnt freeze

[lguenth]

Just chiming into say that this seems to be the same error as in #26.

[claremacrae]

Thanks Luke.

Because the error is caught, it's unclear to me how this could be preventing the rest of Obsidian from starting up.

(I'm not saying it isn't, only that I can't see how...)

[phibr0]

I am aware of the issue, haven't had time to dig into it though.

The //@ts-ignore is interesting. Does it suggest that there is a possible error case that is being ignored?

The @ts-ignore is only there to disable the type checker, since the commands object isn't exposed in Obsidian's type definitions.

I will try to find some time today or later this weekend!

[claremacrae]

Brilliant - thanks very much for fixing this.