Skip to content

Commit

Permalink
Add assertions to remind devs that there should be a LinkedElement to…
Browse files Browse the repository at this point in the history
… the associated Property and that the Property itself should be featured, see phetsims/sun#920
  • Loading branch information
samreid committed Dec 30, 2024
1 parent 1cf2b55 commit 3566314
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions js/wave-on-a-string/model/WOASModel.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,14 @@ class WOASModel extends PhetioObject {
// @public {Property.<WOASModel.Mode>}
this.waveModeProperty = new EnumerationDeprecatedProperty( WOASModel.Mode, WOASModel.Mode.MANUAL, {
tandem: tandem.createTandem( 'waveModeProperty' ),
phetioFeatured: true,
phetioDocumentation: 'what is on the left side of the string, controlling its motion'
} );

// @public {Property.<WOASModel.EndType}
this.endTypeProperty = new EnumerationDeprecatedProperty( WOASModel.EndType, WOASModel.EndType.FIXED_END, {
tandem: tandem.createTandem( 'endTypeProperty' ),
phetioFeatured: true,
phetioDocumentation: 'what is on the right side of the string'
} );

Expand All @@ -71,6 +73,7 @@ class WOASModel extends PhetioObject {
// @public {Property.<TimeSpeed>}
this.timeSpeedProperty = new EnumerationProperty( TimeSpeed.NORMAL, {
tandem: tandem.createTandem( 'timeSpeedProperty' ),
phetioFeatured: true,
validValues: [ TimeSpeed.NORMAL, TimeSpeed.SLOW ],
phetioDocumentation: 'the play speed for the simulation as it moves through time'
} );
Expand Down

0 comments on commit 3566314

Please sign in to comment.