-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert PhetioDynamicElementContainer and subclasses to TypeScript #254
Comments
This also benefited from converting Emitter and Action to TS. I followed precedent in TinyEmitter, and that worked OK. There are several TODOs, any and ts-ignore in the PhetioDynamicElementContainer classes, but it's providing much better type support in simulation usage (as tested in CAS). The main issue that should be worked on next is inference of the creation args--right now it is fully explicit and must be specified manually, like |
@jonathanolson and I did a mini-review and we think the scenery changes are good. We also think the array pattern from TinyEmitter will work for the PhetioGroup and related classes. |
I have some of these next steps in my working copy. Commits coming soon. |
The majority of this work is as follows:
@samreid, Can you take a look and see if you see more to do in PhetioDynamicElementContainers and PhetioObject? |
…nal and improve type for PhetioGroupOptions, see #254
@marlitas and I made improvements in the commit, but ran into one problem with |
For phetsims/center-and-variability#26, we would like PhetioGroup in particular to be in TypeScript. I'll take a look. Also noting that converting common code to TypeScript is one of my 2022 Q1 goals.
The text was updated successfully, but these errors were encountered: